Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Final retry for deleting elasticache security group #8981

Merged
merged 1 commit into from
Jun 13, 2019
Merged

Final retry for deleting elasticache security group #8981

merged 1 commit into from
Jun 13, 2019

Conversation

ryndaniels
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Reference #7873

Release note for CHANGELOG:

BUG FIXES:
* resource/aws_elasticache_security_group: Final retry after timeout when deleting elasticache security group

Output from acceptance testing:

$ TF_ACC=1 go test ./... -v -parallel 1 -run=TestAccAWSElasticacheSecurityGroup -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSElasticacheSecurityGroup_basic
=== PAUSE TestAccAWSElasticacheSecurityGroup_basic
=== RUN   TestAccAWSElasticacheSecurityGroup_Import
=== PAUSE TestAccAWSElasticacheSecurityGroup_Import
=== CONT  TestAccAWSElasticacheSecurityGroup_basic
--- PASS: TestAccAWSElasticacheSecurityGroup_basic (24.46s)
=== CONT  TestAccAWSElasticacheSecurityGroup_Import
--- PASS: TestAccAWSElasticacheSecurityGroup_Import (24.74s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       49.993s

@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/elasticache Issues and PRs that pertain to the elasticache service. labels Jun 13, 2019
@ryndaniels ryndaniels requested a review from bflad June 13, 2019 08:32
@ryndaniels ryndaniels added the bug Addresses a defect in current functionality. label Jun 13, 2019
@bflad bflad added this to the v2.15.0 milestone Jun 13, 2019
bflad
bflad approved these changes Jun 13, 2019
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀 Merging so we can release this today.

--- PASS: TestAccAWSElasticacheSecurityGroup_basic (16.19s)
--- PASS: TestAccAWSElasticacheSecurityGroup_Import (18.38s)

@bflad bflad merged commit 6f3904e into master Jun 13, 2019
@bflad bflad deleted the rfd-retry branch June 13, 2019 19:21
bflad added a commit that referenced this pull request Jun 13, 2019
@bflad
Update CHANGELOG for #8981
5122311
@ghost
Copy link

ghost commented Nov 3, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. service/elasticache Issues and PRs that pertain to the elasticache service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v2.15.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ryndaniels @bflad